Re: [PATCH] Silence iconv warnings on Leopard

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Dec 7, 2007, 00:30 UTC
Message-ID: <alpine.LFD.0.9999.0712061628070.13796@woody.linux-foundation.org>
In-Reply-To: <200712070111.23283.jnareb@gmail.com>

On Fri, 7 Dec 2007, Jakub Narebski wrote:

Show 9 quoted lines

>
> The problem is that it should be check that tests for compile time 
> _warnings_; my solution was to use '-Werror' flag to make warning into 
> error, and AC_COMPILE_IFELSE, but this might be gcc only solution.
> 
>   Message-ID: <1196895948-25115-1-git-send-email-jnareb@gmail.com>
>   http://permalink.gmane.org/gmane.comp.version-control.git/67209
> 
> So please send it.

Umm. Why not just make the test be whether the following compiles cleanly?

	#include <iconv.h>
	
	extern size_t iconv(iconv_t cd,
	  char **inbuf, size_t *inbytesleft,
	  char **outbuf, size_t *outbytesleft);

because if the compiler has seen a "const char **inbuf", then it should error out with a "conflicting types for ‘iconv’" style message..

Just do

	 $CC -c test-iconv.c

or something.

Totally untested. I don't do autoconf.

		Linus