From: Blake Ramsdell Date: Thu, 06 Dec 2007 23:04:08 GMT Subject: Re: [PATCH] Silence iconv warnings on Leopard Message-ID: <985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com> In-Reply-To: <1196968023-45284-1-git-send-email-win@wincent.com> On Dec 6, 2007 11:07 AM, Wincent Colaiuta wrote: > Apple ships a newer version of iconv with Leopard (Mac OS X 10.5/Darwin > 9). Ensure that OLD_ICONV is not set on any version of Darwin in the > 9.x series; this should be good for at least a couple of years, when > Darwin 10 comes out and we can invert the sense of the test to > specifically check for Darwin 7 or 8. This approach seems fine to me, there was some concern about matching the OS type / version in the past, but I haven't really seen a better answer. > A more sophisticated and robust check is possible for those who use > autoconf, but not everybody does that. I did make a patch for configure.ac that does this. If it's interesting, I'll send it along. Blake -- Blake Ramsdell | http://www.blakeramsdell.com