Re: [PATCH v2 1/8] config: Trivial rename in preparation for parseopt.

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 17, 2009, 13:59 UTC
Message-ID: <94a0d4530902170559r74d0b9acyea9be124ece0adeb@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0902171300450.6185@intel-tinevez-2-302>

On Tue, Feb 17, 2009 at 2:01 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 13 quoted lines

> Hi,
>
> On Tue, 17 Feb 2009, Felipe Contreras wrote:
>
>>         free(repo_config);
>> +       if (found == 0)
>> +               error("no config file found");
>>         return ret;
>
> Err, you mean "return error(..)"?
>
> But it might be not an error at all: think of "cd / && git ls-remote $URL"
> without /etc/gitconfig nor $HOME/.gitconfig.

Yeah, I thought about that when doing the patch. I've removed the error(), now it will only return -1. Almost nobody is checking the return code anyways.

-- 
Felipe Contreras