Re: [PATCH v2 8/8] config: Cleanup editor action.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 17, 2009, 02:28 UTC
- Message-ID
- <7vskmdaj9z.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1234832094-15541-8-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Copy-paste from Johannes Schindelin.
Sorry, I do not understand. Are you saying:
(1) This duplicated code was introduced by copy-and-paste by Dscho and I
am cleaning up his mess?or
(2) This change came from Dscho and I am just sending it by copy-pasting
what he did?If the latter, then this is not a good way to describe what happened. You would use in-body From: header to give attribution, and more importantly, you need to say what you would usually say in the commit log message (what it does, why the original is bad, etc.)