Re: [PATCH v2 1/8] config: Trivial rename in preparation for parseopt.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 17, 2009, 01:45 UTC
Message-ID: <7v3aedet0j.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234832094-15541-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 14 quoted lines

> When using the --list option general errors where not properly reported,
> only errors related with the 'file'. Now they are reported, and 'file'
> is irrelevant.
> ...
> @@ -299,10 +300,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)
>  		else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l")) {
>  			if (argc != 2)
>  				usage(git_config_set_usage);
> -			if (git_config(show_all_config, NULL) < 0 &&
> -					file && errno)
> -				die("unable to read config file %s: %s", file,
> -				    strerror(errno));
> +			if (git_config(show_all_config, NULL) < 0)
> +				die("error processing config file(s)");

Does the author of 93a56c2 (git-config: print error message if the config file cannot be read, 2007-10-12) have any comment on this change (cc:ed)?