Re: [PATCH 0/8] asciidoc fixups

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 14, 2015, 07:43 UTC
Message-ID: <9350a00074264bb847210410a6f6c340@www.dscho.org>
In-Reply-To: <20150514042544.GA9351@peff.net>

Hi Brian and Peff,

On 2015-05-14 06:25, Jeff King wrote:

Show 23 quoted lines

> On Wed, May 13, 2015 at 10:41:31PM +0000, brian m. carlson wrote:
> 
>> I've been in contact with Dan Allen, the lead on the Asciidoctor
>> project.  There are a few things that he pointed out.
> 
> Thanks. I was hoping you would get involved. :)
> 
>> >   - asciidoctor does not render {litdd}, which is our invention; locally
>> >     this may be because I did not have the right incantation, but it is
>> >     also broken on git-scm.com. I think the right fix is to define that
>> >     attribute for the site renderer (so not a bug in our sources, and
>> >     not an asciidoctor bug)
>>
>> I passed this as a command-line argument when using asciidoctor to
>> generate the docs: -a litdd=--.  For the site, I would recommend just
>> defining it there, as you suggested.
> 
> Yeah, I tried what you wrote earlier in [1], but it didn't work. But I
> just realized it has misplaced quotes. Doing:
> 
>   make ... ASCIIDOC_EXTRA="-a 'litdd=&#45;&#45;'"
> 
> seems to work OK.

Oh darn, I really meant to include this link:

https://github.com/git-for-windows/MINGW-packages/blob/af36666c829f64847737e783c34ab20402030648/mingw-w64-git/PKGBUILD#L71

which documents how Git for Windows defines `litdd`.

Sorry! Dscho