git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] asciidoc fixups

From
Jeff King <peff@peff.net>
Date
May 14, 2015, 21:17 UTC
Message-ID
<20150514211727.GA15528@peff.net>
In-Reply-To
<xmqqwq0aj25e.fsf@gitster.dls.corp.google.com>
On Thu, May 14, 2015 at 02:10:53PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> >> My asciidoctor just comes from the Debian package. Looks like it's over
> >> a year old at this point. I should probably be testing with something
> >> more recent.
> >
> > We installed asciidoctor via `gem` and have version 1.5.2.
> 
> What I'll be pushing out today will have some "interesting" mark-up
> in Documentation/git-cat-file.txt (on 'jch' or 'pu') from David's
> '--follow-symlinks' topic.  I think AsciiDoc formatting looks OK,
> but can you check it with both older (peff) and newer (dscho)
> asciidoctor to see how well it shows?  Look for --follow-symlinks
> in the output.

What's in 366bc15e9 (your SQUASH) looks terrible with older asciidoctor. The "[normal]" bumps us out of the list item, left-aligning all of the other paragraphs, and then the "+" continuation is treated literally (probably because we are not inside a block).

I don't see any reason we cannot use normal "+" continuation here (but the hanging paragraphs need to be left-aligned, then).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 33 of 37 in “doc: fix unmatched code fences”
  1. doc: fix unmatched code fencesJean-Noel Avila, May 12, 2015
  2. Junio C HamanoMay 12, 2015
  3. Jeff KingMay 13, 2015
  4. Junio C HamanoMay 13, 2015
  5. Jeff KingMay 13, 2015
  6. Junio C HamanoMay 13, 2015
  7. Jeff KingMay 13, 2015
  8. brian m. carlsonMay 13, 2015
  9. 0/8 asciidoc fixupsJeff King, May 13, 2015
  10. 1/8 doc: fix misrendering due to `single quote'Jeff King, May 13, 2015
  11. 2/8 doc: fix unquoted use of "{type}"Jeff King, May 13, 2015
  12. 3/8 doc: fix hanging "+"-continuationJeff King, May 13, 2015
  13. 4/8 doc: fix length of underlined section-titleJeff King, May 13, 2015
  14. 5/8 doc/add: reformat `--edit` optionJeff King, May 13, 2015
  15. 6/8 doc: convert \--option to --optionJeff King, May 13, 2015
  16. John KeepingMay 13, 2015
  17. Jeff KingMay 14, 2015
  18. Junio C HamanoMay 17, 2015
  19. 7/8 doc: drop backslash quoting of some curly bracesJeff King, May 13, 2015
  20. 8/8 doc: put example URLs and emails inside literal backticksJeff King, May 13, 2015
  21. Jeff KingMay 13, 2015
  22. Junio C HamanoMay 13, 2015
  23. Jeff KingMay 13, 2015
  24. Johannes SchindelinMay 13, 2015
  25. Jeff KingMay 14, 2015
  26. brian m. carlsonMay 13, 2015
  27. Jeff KingMay 14, 2015
  28. 9/8 doc: convert AsciiDoc {?foo} to ifdef::foo[]Jeff King, May 14, 2015
  29. Johannes SchindelinMay 14, 2015
  30. Jeff KingMay 14, 2015
  31. Johannes SchindelinMay 14, 2015
  32. Junio C HamanoMay 14, 2015
  33. Jeff KingMay 14, 2015
  34. Junio C HamanoMay 14, 2015
  35. David TurnerMay 14, 2015
  36. brian m. carlsonMay 15, 2015
  37. Jeff KingMay 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.