Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
- From
- Perry Wagle <wagle@cs.indiana.edu>
- Date
- Aug 28, 2008, 23:55 UTC
- Message-ID
- <928D2C14-23B9-4351-BBB2-234A94980E83@cs.indiana.edu>
- In-Reply-To
- <20080828234506.GA30195@coredump.intra.peff.net>
Okay, thanks for the analysis! He pulled a minor remark out and said I didn't look, when I had. I have other things to do this week, but this thread is now, so I gotta do the ballpark measurements now (with some hope of reversing a upward compatibility breakage, which isn't important any more, see my other post). Later I go in and s/git<DASH>/ git<SPACE>/g in my one-true-editor 8) and see for sure how many I actually need to change. Gitweb wasn't my main problem, just one I had to think about when I can sit down and test the upgrade to 1.6.0.
-- Perry
On Aug 28, 2008, at 4:45 PM, Jeff King wrote:
Show 27 quoted lines
> On Thu, Aug 28, 2008 at 04:14:14PM -0700, Perry Wagle wrote: > >> I did: >> >> pwagle@starscream:/usr/lib/cgi-bin$ ls -l >> total 352 >> -rw-r--r-- 1 root root 164 2008-03-07 12:03 git-favicon.png >> -rw-r--r-- 1 root root 208 2008-03-07 12:03 git-logo.png >> -rwxr-xr-x 1 root root 167729 2008-03-07 12:03 gitweb.cgi >> -rw-r--r-- 1 root root 7112 2008-03-07 12:03 gitweb.css >> -rwxr-xr-x 1 root root 167932 2008-03-07 12:03 gitweb.perl >> pwagle@starscream:/usr/lib/cgi-bin$ grep git- * | wc -l >> 68 >> pwagle@starscream:/usr/lib/cgi-bin$ > > 1. Your numbers are doubled because gitweb.cgi is the built form of > gitweb.perl. > > 2. Look at the grep output. They are all in comments or messages. > Perhaps the messages should say "open git diff failed" instead of > "open > git-diff failed". But the "git-foo" form has been kept as a > typographical convention because it makes more sense from a language > perspective (just as you would hyphenate some compound words, or an > adjective phrase). Perhaps that is a mistake, given the confusion. > > -Peff