git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/9] convert "oidcmp() == 0" to oideq()

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 27, 2018, 12:33 UTC
Message-ID
<909de6f4-0b30-b9d9-637c-a86497f86d8e@gmail.com>
In-Reply-To
<62172db4-15b2-eac3-8591-246300db3948@gmail.com>
On 8/27/2018 8:31 AM, Derrick Stolee wrote:
Show 15 quoted lines
> On 8/25/2018 4:36 AM, Jeff King wrote:
>> On Sat, Aug 25, 2018 at 04:07:15AM -0400, Jeff King wrote:
>>
>>> diff --git a/contrib/coccinelle/object_id.cocci 
>>> b/contrib/coccinelle/object_id.cocci
>>> index 5869979be7..548c02336d 100644
>>> --- a/contrib/coccinelle/object_id.cocci
>>> +++ b/contrib/coccinelle/object_id.cocci
>>> @@ -108,3 +108,9 @@ expression E1, E2;
>>>   @@
>>>   - hashcpy(E1.hash, E2->hash)
>>>   + oidcpy(&E1, E2)
>
> Is this change intended? It doesn't seem to match the intention of the 
> rest of the patch.

Ignore me. It's just confusing to read the +/- notation from a cocci script alongside the file diff.

Previous: Derrick StoleeNext: Jeff King
Message 8 of 30 in “introducing oideq()”
  1. 0/9 introducing oideq()Jeff King, Aug 25, 2018
  2. 1/9 coccinelle: use <...> for function exclusionJeff King, Aug 25, 2018
  3. 2/9 introduce hasheq() and oideq()Jeff King, Aug 25, 2018
  4. Andrei RybakAug 25, 2018
  5. 3/9 convert "oidcmp() == 0" to oideq()Jeff King, Aug 25, 2018
  6. Jeff KingAug 25, 2018
  7. Derrick StoleeAug 27, 2018
  8. Derrick StoleeAug 27, 2018
  9. 4/9 convert "hashcmp() == 0" to hasheq()Jeff King, Aug 25, 2018
  10. 5/9 convert "oidcmp() != 0" to "!oideq()"Jeff King, Aug 25, 2018
  11. 6/9 convert "hashcmp() != 0" to "!hasheq()"Jeff King, Aug 25, 2018
  12. 7/9 convert hashmap comparison functions to oideq()Jeff King, Aug 25, 2018
  13. 8/9 read-cache: use oideq() in ce_compare functionsJeff King, Aug 25, 2018
  14. 9/9 show_dirstat: simplify same-content checkJeff King, Aug 25, 2018
  15. Eric SunshineAug 25, 2018
  16. Jeff KingAug 25, 2018
  17. brian m. carlsonAug 26, 2018
  18. Derrick StoleeAug 27, 2018
  19. Jeff KingAug 28, 2018
  20. 1/9 coccinelle: use <...> for function exclusionJeff King, Aug 28, 2018
  21. 2/9 introduce hasheq() and oideq()Jeff King, Aug 28, 2018
  22. 3/9 convert "oidcmp() == 0" to oideq()Jeff King, Aug 28, 2018
  23. 4/9 convert "hashcmp() == 0" to hasheq()Jeff King, Aug 28, 2018
  24. 5/9 convert "oidcmp() != 0" to "!oideq()"Jeff King, Aug 28, 2018
  25. 6/9 convert "hashcmp() != 0" to "!hasheq()"Jeff King, Aug 28, 2018
  26. 7/9 convert hashmap comparison functions to oideq()Jeff King, Aug 28, 2018
  27. 8/9 read-cache: use oideq() in ce_compare functionsJeff King, Aug 28, 2018
  28. 9/9 show_dirstat: simplify same-content checkJeff King, Aug 28, 2018
  29. Derrick StoleeAug 28, 2018
  30. brian m. carlsonAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.