From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 27 Aug 2018 12:33:25 GMT
Subject: Re: [PATCH 3/9] convert "oidcmp() == 0" to oideq()
Message-ID: <909de6f4-0b30-b9d9-637c-a86497f86d8e@gmail.com>
In-Reply-To: <62172db4-15b2-eac3-8591-246300db3948@gmail.com>

On 8/27/2018 8:31 AM, Derrick Stolee wrote:
> On 8/25/2018 4:36 AM, Jeff King wrote:
>> On Sat, Aug 25, 2018 at 04:07:15AM -0400, Jeff King wrote:
>>
>>> diff --git a/contrib/coccinelle/object_id.cocci 
>>> b/contrib/coccinelle/object_id.cocci
>>> index 5869979be7..548c02336d 100644
>>> --- a/contrib/coccinelle/object_id.cocci
>>> +++ b/contrib/coccinelle/object_id.cocci
>>> @@ -108,3 +108,9 @@ expression E1, E2;
>>>   @@
>>>   - hashcpy(E1.hash, E2->hash)
>>>   + oidcpy(&E1, E2)
>
> Is this change intended? It doesn't seem to match the intention of the 
> rest of the patch.

Ignore me. It's just confusing to read the +/- notation from a cocci 
script alongside the file diff.