git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rename_ref(): only print a warning when config-file update fails

From
LHLars Hjemli <hjemli@gmail.com>
Date
Apr 6, 2007, 23:53 UTC
Message-ID
<8c5c35580704061653x7e5fd149ud31a8289a4508b54@mail.gmail.com>
In-Reply-To
<7v1wixkzpz.fsf@assigned-by-dhcp.cox.net>
On 4/6/07, Junio C Hamano <junkio@cox.net> wrote:
Show 9 quoted lines
> Lars Hjemli <hjemli@gmail.com> writes:
>
> > If git_config_rename_section() fails, rename_ref() used to return 1, which
> > left HEAD pointing to an absent refs/heads file (since the actual renaming
> > had already occurred).
>
> I wonder if rolling back the rename that was asked is an
> option.  We would want to keep these low-level things atomic
> whenever possible.

I was wondering the same thing, i.e. "goto rollback" as an option for "error()". But I ended up thinking that rename_ref() shouldn't bother with the config file at all (thus my other patch).

-- 
larsh
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “rename_ref(): only print a warning when config-file update fails”
  1. rename_ref(): only print a warning when config-file update failsLars Hjemli, Apr 6, 2007
  2. Geert BoschApr 6, 2007
  3. Junio C HamanoApr 6, 2007
  4. Lars HjemliApr 6, 2007
  5. Junio C HamanoApr 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.