Re: [PATCH] rename_ref(): only print a warning when config-file update fails

From: Junio C Hamano <junkio@cox.net>
Date: Apr 7, 2007, 00:14 UTC
Message-ID: <7v6489hwfy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8c5c35580704061653x7e5fd149ud31a8289a4508b54@mail.gmail.com>

"Lars Hjemli" <hjemli@gmail.com> writes:

Show 7 quoted lines

>> I wonder if rolling back the rename that was asked is an
>> option.  We would want to keep these low-level things atomic
>> whenever possible.
>
> I was wondering the same thing, i.e. "goto rollback" as an option for
> "error()". But I ended up thinking that rename_ref() shouldn't bother
> with the config file at all (thus my other patch).

I agree that "other patch" is sensible regardless.