From: Lars Hjemli <hjemli@gmail.com>
Date: Fri, 06 Apr 2007 23:53:43 GMT
Subject: Re: [PATCH] rename_ref(): only print a warning when config-file update fails
Message-ID: <8c5c35580704061653x7e5fd149ud31a8289a4508b54@mail.gmail.com>
In-Reply-To: <7v1wixkzpz.fsf@assigned-by-dhcp.cox.net>

On 4/6/07, Junio C Hamano <junkio@cox.net> wrote:
> Lars Hjemli <hjemli@gmail.com> writes:
>
> > If git_config_rename_section() fails, rename_ref() used to return 1, which
> > left HEAD pointing to an absent refs/heads file (since the actual renaming
> > had already occurred).
>
> I wonder if rolling back the rename that was asked is an
> option.  We would want to keep these low-level things atomic
> whenever possible.

I was wondering the same thing, i.e. "goto rollback" as an option for
"error()". But I ended up thinking that rename_ref() shouldn't bother
with the config file at all (thus my other patch).

-- 
larsh