Re: [PATCH] t7407: use test_grep

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jan 7, 2025, 22:09 UTC
Message-ID: <8aa4e7d9-b77b-4f29-9564-5c1d4ec5be0a@app.fastmail.com>
In-Reply-To: <xmqq5xmqs95j.fsf@gitster.g>

On Tue, Jan 7, 2025, at 20:42, Junio C Hamano wrote:

Show 12 quoted lines

> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>> On Tue, Jan 7, 2025, at 08:18, Jeff King wrote:
>>> get rid of them.
>>>
>>> (It is also curious to grep in the expected file in the first place, but
>>> that is because we are auto-generating the expectation from a Git
>>> command. So this is double-checking it did what we wanted).
>>
>> Missing “that”? s/it did/that it did/
>
> It is colloquially correct, isn't it?

I’m just going by intuition but I couldn’t make it make sense in my head/read out loud.

-- 
Kristoffer Haugsbakk