From: Kristoffer Haugsbakk Date: Tue, 07 Jan 2025 22:09:33 GMT Subject: Re: [PATCH] t7407: use test_grep Message-ID: <8aa4e7d9-b77b-4f29-9564-5c1d4ec5be0a@app.fastmail.com> In-Reply-To: On Tue, Jan 7, 2025, at 20:42, Junio C Hamano wrote: > "Kristoffer Haugsbakk" writes: > >> On Tue, Jan 7, 2025, at 08:18, Jeff King wrote: >>> get rid of them. >>> >>> (It is also curious to grep in the expected file in the first place, but >>> that is because we are auto-generating the expectation from a Git >>> command. So this is double-checking it did what we wanted). >> >> Missing “that”? s/it did/that it did/ > > It is colloquially correct, isn't it? I’m just going by intuition but I couldn’t make it make sense in my head/read out loud. -- Kristoffer Haugsbakk