Re: [PATCH] t7407: use test_grep

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Jan 7, 2025, 23:36 UTC
Message-ID: <CALnO6CAUZBB28vCjMF8HRxvdv=N6y6OVyXZF2Yh4rK8c-sQU1A@mail.gmail.com>
In-Reply-To: <xmqq5xmqs95j.fsf@gitster.g>

On Tue, Jan 7, 2025 at 2:42 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
> > On Tue, Jan 7, 2025, at 08:18, Jeff King wrote:
> >> get rid of them.
> >>
> >> (It is also curious to grep in the expected file in the first place, but
> >> that is because we are auto-generating the expectation from a Git
> >> command. So this is double-checking it did what we wanted).
> >
> > Missing “that”? s/it did/that it did/
>
> It is colloquially correct, isn't it?
>
>

Reads fine to me.

-- 
D. Ben Knoble