git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] t0050: use the SYMLINKS test prereq

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jul 26, 2012, 13:39 UTC
Message-ID
<8a35a99e9694af4cccda19199c7543d748d41d73.1343309173.git.git@drmicha.warpmail.net>
In-Reply-To
<5001B82B.1060201@web.de>
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 t/t0050-filesystem.sh | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index df9498b..b46ae72 100755
--- a/t/t0050-filesystem.sh
+++ b/t/t0050-filesystem.sh
@@ -8,7 +8,6 @@ auml=$(printf '\303\244')
 aumlcdiar=$(printf '\141\314\210')
 
 unibad=
-no_symlinks=
 test_expect_success 'see what we expect' '
 
 	test_unicode=test_expect_success &&
@@ -21,13 +20,7 @@ test_expect_success 'see what we expect' '
 		;;
 	*)	;;
 	esac &&
-	rm -fr junk &&
-	{
-		ln -s x y 2> /dev/null &&
-		test -h y 2> /dev/null ||
-		no_symlinks=1 &&
-		rm -f y
-	}
+	rm -fr junk
 '
 
 if test_have_prereq CASE_INSENSITIVE_FS
@@ -40,7 +33,7 @@ fi
 
 test "$unibad" &&
 	say "will test on a unicode corrupting filesystem"
-test "$no_symlinks" &&
+test_have_prereq SYMLINKS ||
 	say "will test on a filesystem lacking symbolic links"
 
 if test_have_prereq CASE_INSENSITIVE_FS
@@ -57,18 +50,18 @@ test_expect_success "detection of case insensitive filesystem during repo init"
 '
 fi
 
-if test "$no_symlinks"
+if test_have_prereq SYMLINKS
 then
 test_expect_success "detection of filesystem w/o symlink support during repo init" '
 
-	v=$(git config --bool core.symlinks) &&
-	test "$v" = false
+	test_must_fail git config --bool core.symlinks ||
+	test "$(git config --bool core.symlinks)" = true
 '
 else
 test_expect_success "detection of filesystem w/o symlink support during repo init" '
 
-	test_must_fail git config --bool core.symlinks ||
-	test "$(git config --bool core.symlinks)" = true
+	v=$(git config --bool core.symlinks) &&
+	test "$v" = false
 '
 fi
 
-- 
1.7.12.rc0.198.gd66b616
Previous: Michael J GruberNext: Michael J Gruber
Message 17 of 19 in “t3910: give reason for skipping the test”
  1. t3910: give reason for skipping the testMichael J Gruber, Jul 14, 2012
  2. Torsten BögershausenJul 14, 2012
  3. 0/5 test-lib: filesystem prerequisitesMichael J Gruber, Jul 26, 2012
  4. Junio C HamanoJul 26, 2012
  5. Jeff KingJul 26, 2012
  6. Junio C HamanoJul 26, 2012
  7. Michael J GruberJul 27, 2012
  8. Junio C HamanoJul 27, 2012
  9. Michael J GruberJul 30, 2012
  10. 5/5 t3910: use the UTF8_NFD_TO_NFC test prereqMichael J Gruber, Jul 30, 2012
  11. Junio C HamanoJul 30, 2012
  12. Torsten BögershausenAug 4, 2012
  13. Junio C HamanoAug 4, 2012
  14. Michael J GruberAug 6, 2012
  15. 1/5 test-lib: provide case insensitivity as a prerequisiteMichael J Gruber, Jul 26, 2012
  16. 2/5 t0050: use the CASE_INSENSITIVE_FS test prereqMichael J Gruber, Jul 26, 2012
  17. 3/5 t0050: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012
  18. 4/5 test-lib: provide UTF8 behaviour as a prerequisiteMichael J Gruber, Jul 26, 2012
  19. 5/5 t3910: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.