git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] test-lib: filesystem prerequisites

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jul 27, 2012, 09:31 UTC
Message-ID
<50126005.7060202@drmicha.warpmail.net>
In-Reply-To
<7vzk6m5ln9.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 26.07.2012 22:10:
Show 20 quoted lines
> Jeff King <peff@peff.net> writes:
> 
>> That looks like a maintenance annoyance. Can't we just have the
>> prerequisite-checker lazily perform the test on demand and cache the
>> result?  It should be OK as long as:
>>
>>   1. The prereq is careful about its pre- and post- conditions. We
>>      already make sure to clean up after those tests so as not to taint
>>      later tests. We would probably want to also make them more careful
>>      about preconditions like which directory they are in (so, for
>>      example, refer to "$TRASH_DIRECTORY/junk" and not "junk").
>>
>>   2. The prereq test does not accidentally munge any existing test
>>      state from previous tests. That should not be a big deal as long as
>>      we avoid names like "junk" in favor of more unique names like
>>      "check-case-sensitivity-prereq".
> 
> Yeah, it is very desirable if we could lazy-eval, and we _should_ be
> able to arrange the above.
> 
Yes, lazy-eval looks good and is probably easier than caching.
The adjustments to 1/5 and 4/5 look good.
5/5 needs a fix in the subject line, sorry. It should be:
t3910: use the UTF8_NFD_TO_NFC test prereq
(5/5 hasn't hit next)

Thanks, Michael

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 19 in “t3910: give reason for skipping the test”
  1. t3910: give reason for skipping the testMichael J Gruber, Jul 14, 2012
  2. Torsten BögershausenJul 14, 2012
  3. 0/5 test-lib: filesystem prerequisitesMichael J Gruber, Jul 26, 2012
  4. Junio C HamanoJul 26, 2012
  5. Jeff KingJul 26, 2012
  6. Junio C HamanoJul 26, 2012
  7. Michael J GruberJul 27, 2012
  8. Junio C HamanoJul 27, 2012
  9. Michael J GruberJul 30, 2012
  10. 5/5 t3910: use the UTF8_NFD_TO_NFC test prereqMichael J Gruber, Jul 30, 2012
  11. Junio C HamanoJul 30, 2012
  12. Torsten BögershausenAug 4, 2012
  13. Junio C HamanoAug 4, 2012
  14. Michael J GruberAug 6, 2012
  15. 1/5 test-lib: provide case insensitivity as a prerequisiteMichael J Gruber, Jul 26, 2012
  16. 2/5 t0050: use the CASE_INSENSITIVE_FS test prereqMichael J Gruber, Jul 26, 2012
  17. 3/5 t0050: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012
  18. 4/5 test-lib: provide UTF8 behaviour as a prerequisiteMichael J Gruber, Jul 26, 2012
  19. 5/5 t3910: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.