git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3910: give reason for skipping the test

From
Torsten Bögershausen <tboegi@web.de>
Date
Jul 14, 2012, 18:19 UTC
Message-ID
<5001B82B.1060201@web.de>
In-Reply-To
<71c43b6e469c916f6c41026ad6ed25c1094018be.1342287902.git.git@drmicha.warpmail.net>
On 14.07.12 19:52, Michael J Gruber wrote:
Show 13 quoted lines
> t3910 is skipped for most users because it requires a filesystem which
> does automatic conversion between different utf-8 types. Currently, this
> results in a skipped test with "no reason given".
> 
> Use the skip_all mechanism from our test suite so that a reason for
> skipping the test is given to the user.
> 
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> Alternatively, we could set a prerequisite and mark all tests with that.  Since
> it's either or for the whole test skip_all seems more appropriate.  In that
> case, we can also flatten the else branch, of course. The current patch is
> minimally invasive, though.
Good point, thanks.

If we spin that idea further, we could move the whole t3910 into t0050.

That would be nice for all non Mac OS X users in a way that we save CPU time. We already detect unicode corruption in t0050.

Previous: Michael J GruberNext: Michael J Gruber
Message 2 of 19 in “t3910: give reason for skipping the test”
  1. t3910: give reason for skipping the testMichael J Gruber, Jul 14, 2012
  2. Torsten BögershausenJul 14, 2012
  3. 0/5 test-lib: filesystem prerequisitesMichael J Gruber, Jul 26, 2012
  4. Junio C HamanoJul 26, 2012
  5. Jeff KingJul 26, 2012
  6. Junio C HamanoJul 26, 2012
  7. Michael J GruberJul 27, 2012
  8. Junio C HamanoJul 27, 2012
  9. Michael J GruberJul 30, 2012
  10. 5/5 t3910: use the UTF8_NFD_TO_NFC test prereqMichael J Gruber, Jul 30, 2012
  11. Junio C HamanoJul 30, 2012
  12. Torsten BögershausenAug 4, 2012
  13. Junio C HamanoAug 4, 2012
  14. Michael J GruberAug 6, 2012
  15. 1/5 test-lib: provide case insensitivity as a prerequisiteMichael J Gruber, Jul 26, 2012
  16. 2/5 t0050: use the CASE_INSENSITIVE_FS test prereqMichael J Gruber, Jul 26, 2012
  17. 3/5 t0050: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012
  18. 4/5 test-lib: provide UTF8 behaviour as a prerequisiteMichael J Gruber, Jul 26, 2012
  19. 5/5 t3910: use the SYMLINKS test prereqMichael J Gruber, Jul 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.