git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add commit.status, --status, and --no-status

From
JPJames Pickens <jepicken@gmail.com>
Date
Dec 8, 2009, 00:39 UTC
Message-ID
<885649360912071639o4c609dbapea9891aae639194c@mail.gmail.com>
In-Reply-To
<1260225927-33612-1-git-send-email-jh@jameshoward.us>
On Mon, Dec 7, 2009, James P. Howard, II <jh@jameshoward.us> wrote:
Show 5 quoted lines
> This commit provides support for commit.status, --status, and
> --no-status, which control whether or not the git status information
> is included in the commit message template when using an editor to
> prepare the commit message.  It does not affect the effects of a
> user's commit.template settings.

At the risk of sounding like a curmudgeon, I have to register an objection to this _as a config option_, for the same reasons that I objected to the 'grep --full-tree' config option [1]. Both options fundamentally change user visible behavior, both options IMHO will be used by a small minority of git users, and in both cases, the desired behavior can be attained using aliases in combination with a new command line option.

Sorry if I'm obstructing progress, but I think that, for the good of the Git community as a whole, it's best to keep the number of config options (and to a lesser extent, command line options) as low as possible.

Note that I do not object to adding --no-status as a command line option.
[1] http://article.gmane.org/gmane.comp.version-control.git/133681
James
Previous: James P. Howard, IINext: Jeff King
Message 10 of 15 in “Add commit.infodisplay option to give message editor empty file”
  1. Add commit.infodisplay option to give message editor empty fileJames P. Howard, II, Dec 4, 2009
  2. Junio C HamanoDec 5, 2009
  3. James P. Howard, IIDec 5, 2009
  4. Jeff KingDec 5, 2009
  5. James P. Howard, IIDec 5, 2009
  6. Jeff KingDec 6, 2009
  7. Junio C HamanoDec 6, 2009
  8. Jeff KingDec 6, 2009
  9. Add commit.status, --status, and --no-statusJames P. Howard, II, Dec 7, 2009
  10. James PickensDec 8, 2009
  11. Jeff KingDec 8, 2009
  12. Junio C HamanoDec 8, 2009
  13. Jeff KingDec 8, 2009
  14. James P. Howard, IIDec 8, 2009
  15. James P. Howard, IIDec 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.