git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add commit.infodisplay option to give message editor empty file

From
James P. Howard, II <jh@jameshoward.us>
Date
Dec 5, 2009, 15:47 UTC
Message-ID
<20091205154753.GA3717@thermopylae.local>
In-Reply-To
<7vpr6t6fnz.fsf@alter.siamese.dyndns.org>
On Fri, Dec 04, 2009 at 11:30:56PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Two points and a half:
> 
>  - Why does info_display need to be visible to everybody else by being in
>    cache.h and environment.c?  Shouldn't its scope be similar to that of
>    template_file, that is static to builtin-commit.c?
> 
>  - A configuration variable that does not allow the users to override from
>    the command line is a no-no.  We usually do command line option first
>    and then (or at the same time) configuration variable as a typesaver.
I can make these changes in the next few days.
 
>  - While the amount of change necessary for this change doesn't look too
>    bad, is it really worth it?  What is wrong with "1,$p" while using ed
>    as your editor?

I tried a few variants of this, and shell script wrappers for ex (and gate, which is a specizalized text editor that actually works kind of well for commit message editing), and it worked fairly well.

The real motivation is that this feature ditches all assumptions about the capabilities of the text editor. I am not sure where that leads yet, but I'd rather make it possible.

James
-- 
James P. Howard, II, MPA MBCS
jh@jameshoward.us
Previous: Junio C HamanoNext: Jeff King
Message 3 of 15 in “Add commit.infodisplay option to give message editor empty file”
  1. Add commit.infodisplay option to give message editor empty fileJames P. Howard, II, Dec 4, 2009
  2. Junio C HamanoDec 5, 2009
  3. James P. Howard, IIDec 5, 2009
  4. Jeff KingDec 5, 2009
  5. James P. Howard, IIDec 5, 2009
  6. Jeff KingDec 6, 2009
  7. Junio C HamanoDec 6, 2009
  8. Jeff KingDec 6, 2009
  9. Add commit.status, --status, and --no-statusJames P. Howard, II, Dec 7, 2009
  10. James PickensDec 8, 2009
  11. Jeff KingDec 8, 2009
  12. Junio C HamanoDec 8, 2009
  13. Jeff KingDec 8, 2009
  14. James P. Howard, IIDec 8, 2009
  15. James P. Howard, IIDec 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.