Re: [PATCH] Add commit.status, --status, and --no-status
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 8, 2009, 07:13 UTC
- Message-ID
- <7vr5r6ndkz.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20091208060415.GC9951@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> On Mon, Dec 07, 2009 at 05:45:27PM -0500, James P. Howard, II wrote: > >> This commit provides support for commit.status, --status, and >> --no-status, which control whether or not the git status information >> is included in the commit message template when using an editor to >> prepare the commit message. It does not affect the effects of a >> user's commit.template settings. > > Thanks, this looks very cleanly done. The only complaint I would make is > that it should probably include a simple test case.
Yes. Also I am a _bit_ worried about the name "status", as the longer term direction is to make "status" not "a preview of commit", may confuse people who do read Release Notes.