Re: [PATCH v1 09/27] diff-merges: re-arrange functions to match the order they are called in

From: Sergey Organov <sorganov@gmail.com>
Date: Dec 3, 2020, 15:41 UTC
Message-ID: <87wnxyhp6g.fsf@osv.gnss.ru>
In-Reply-To: <CABPp-BESWpqska++EsfxfbncyV0kNo1RGLjF+1BiV=D6zLx2LQ@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 8 quoted lines

> On Sun, Nov 8, 2020 at 1:43 PM Sergey Organov <sorganov@gmail.com> wrote:
>>
>> For clarity, define public functions in the order they are called, to
>> make logic inter-dependencies easier to grok.
>
> You added diff-merges.[ch] earlier in this series.  Why not just add
> them in the correct order initially instead of adding another patch
> later in the series?

Well, I did consider it, but there are 2 issues that stopped me.

First, I didn't want to rearrange functions as I move them from revision.c, to avoid mixed commit to simplify review, and second, I didn't want to rearrange them in the original to perform as little changes to the codebase as possible before isolating my work into diff-merges.[ch].

Hope it makes sense.

Thanks, -- Sergey Organov