Re: [PATCH v2 23/33] diff-merges: fix style of functions definitions
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Dec 19, 2020, 01:00 UTC
- Message-ID
- <5fdd50b444ea9_1d9522208a0@natae.notmuch>
- In-Reply-To
- <CABPp-BEZ6VqyTah7QCzkuUm-p7tA_6cnpGPWpgpQbHp_c3Wc5Q@mail.gmail.com>
Elijah Newren wrote:
Show 11 quoted lines
> Personally, I think that a really important point to keep in mind when > submitting patch series is trying to figure out the easiest way to > move the code from point A to point B, not the route you took to get > from point A to point B. This is especially true for longer patch > series. It's common after you've finished a series to discover there > was an easier or cleaner route to follow that would have arrived at > the same end-point. It's not uncommon for me to spend a significant > chunk of time rebasing and restructuring a patch series to try to > highlight such a better path. This includes not just style fixups, > but different patch orderings, alternate ways to break up functions, > using different data structures, etc.
Me as well.
It's extra work for one person, but everyone else benefits, including that one person in the future (who usually forgets why he/she did things in that particular way).
Cheers.
-- Felipe Contreras