Re: [PATCH v2 0/5] mktag tests & fix for-each-ref segfault
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Apr 2, 2021, 11:37 UTC
- Message-ID
- <87wntkkjcd.fsf@evledraar.gmail.com>
- In-Reply-To
- <xmqqczvd3hkb.fsf@gitster.g>
On Thu, Apr 01 2021, Junio C Hamano wrote:
Show 8 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> Here's a proposed v2. We test the same case, but I thought it made >> sense to test this more exhaustively. > > Let's first make a targetted fix that can be applied to maint and > below. After that is merged to 'master', you are free to add more > tests on top,
Makes sense. I based Jeff's patch on top of mine to demonstrate that those tests also catch the segfault.
> but let's avoid to have more and more topics that go overboard.
So "submit a new version on-top" or "maybe deal with your existing topics first as you're overflowing my inbox" ? :) I suspect the latter..