From: Ævar Arnfjörð Bjarmason Date: Fri, 02 Apr 2021 11:37:54 GMT Subject: Re: [PATCH v2 0/5] mktag tests & fix for-each-ref segfault Message-ID: <87wntkkjcd.fsf@evledraar.gmail.com> In-Reply-To: On Thu, Apr 01 2021, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Here's a proposed v2. We test the same case, but I thought it made >> sense to test this more exhaustively. > > Let's first make a targetted fix that can be applied to maint and > below. After that is merged to 'master', you are free to add more > tests on top, Makes sense. I based Jeff's patch on top of mine to demonstrate that those tests also catch the segfault. > but let's avoid to have more and more topics that go overboard. So "submit a new version on-top" or "maybe deal with your existing topics first as you're overflowing my inbox" ? :) I suspect the latter..