Re: [PATCH 1/7] object.c: refactor type_from_string_gently()

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 8, 2021, 20:52 UTC
Message-ID: <YEaOeK96r2oo7cbS@nand.local>
In-Reply-To: <20210308200426.21824-2-avarab@gmail.com>

On Mon, Mar 08, 2021 at 09:04:20PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> Get rid of the "gently" argument to type_from_string_gently() to make
> it consistent with most other *_gently() functions.
>
> This refactoring of adding a third parameter was done in
> fe8e3b71805 (Refactor type_from_string() to allow continuing after
> detecting an error, 2014-09-10) in preparation for its use in
> fsck.c.

Makes sense. I don't think it hurts to mention that fe8e3b71805 also wrote the implementation of type_from_string() as:

  #define type_from_string(str) type_from_string_gently(str, -1, 0)

making it the only caller to pass '0' for the 'gentle' parameter. So by implementing it as a function in terms of type_from_string_gently() which checks for a negative return value, we can drop the 'gentle' parameter entirely.

Makes sense.

Thanks, Taylor