Re: [PATCH v3 4/9] builtin/reflog: implement subcommand to write new entries

From: Toon Claes <toon@iotcl.com>
Date: Aug 1, 2025, 11:37 UTC
Message-ID: <87wm7nuvaz.fsf@iotcl.com>
In-Reply-To: <20250729-pks-reflog-append-v3-4-9614d310f073@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> +test_expect_success 'abbreviated object IDs' '
> +	test_when_finished "rm -rf repo" &&
> +	git init repo &&
> +	(
> +		cd repo &&
> +		test_must_fail git reflog write refs/heads/something 12345 $ZERO_OID old-object-id 2>err &&

Is the object id rejected because it's short, or because there simply doesn't exist an object that starts with `12345`? You're not really testing the former, which you claim in the test name.

-- 
Cheers,
Toon

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.