From: Toon Claes <toon@iotcl.com>
Date: Fri, 01 Aug 2025 11:37:40 GMT
Subject: Re: [PATCH v3 4/9] builtin/reflog: implement subcommand to write new entries
Message-ID: <87wm7nuvaz.fsf@iotcl.com>
In-Reply-To: <20250729-pks-reflog-append-v3-4-9614d310f073@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> +test_expect_success 'abbreviated object IDs' '
> +	test_when_finished "rm -rf repo" &&
> +	git init repo &&
> +	(
> +		cd repo &&
> +		test_must_fail git reflog write refs/heads/something 12345 $ZERO_OID old-object-id 2>err &&

Is the object id rejected because it's short, or because there simply
doesn't exist an object that starts with `12345`? You're not really
testing the former, which you claim in the test name.

-- 
Cheers,
Toon