Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> On Mon, Nov 28, 2022 at 05:44:29PM +0300, Sergey Organov wrote:
>
>> >> + if (set_func != NULL) {
>> >
>> > Please write it like so:
>> >
>> > if (set_func) {
>>[...]
>> Thanks! Do we now have tool for auto-check for these issues? I still use
>> one from Linux kernel, and it didn't object to this form.
>
> Running "make coccicheck" will find this, but of course you need to have
> coccinelle installed. Note that if it finds anything, "make" won't
> report an error. You have to check for non-empty files in
> contrib/coccinelle/*.patch.Thank you! I'll give it a try.
-- Sergey Organov
Sergey Organov <sorganov@gmail.com>