Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 29, 2022, 15:30 UTC
- Message-ID
- <xmqqbkop3hjb.fsf@gitster.g>
- In-Reply-To
- <8735a3gmuq.fsf@osv.gnss.ru>
Sergey Organov <sorganov@gmail.com> writes:
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Sergey Organov <sorganov@gmail.com> writes:
>>
>>> + if (set_func != NULL) {
>>
>> Please write it like so:
>>
>> if (set_func) {
>
> OK, will do.
>
>>
>> I am not reviewing any new feature topic during -rc period (yet),
>> but this triggered CI failure at the tip of 'seen', so.
>
> Thanks! Do we now have tool for auto-check for these issues? I still use
> one from Linux kernel, and it didn't object to this form.I noticed it when I pushed to GitHub, which ran the CI ;-)
If you have your own fork at GitHub of https://github.com/git/git/, I think preparing a pull request against it triggers the CI.