From: Sergey Organov <sorganov@gmail.com>
Date: Wed, 30 Nov 2022 13:02:05 GMT
Subject: Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
Message-ID: <87r0xktx2q.fsf@osv.gnss.ru>
In-Reply-To: <Y4ZUAsT7UKguvXiz@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Nov 28, 2022 at 05:44:29PM +0300, Sergey Organov wrote:
>
>> >> +	if (set_func != NULL) {
>> >
>> > Please write it like so:
>> >
>> > 	if (set_func) {
>>[...]
>> Thanks! Do we now have tool for auto-check for these issues? I still use
>> one from Linux kernel, and it didn't object to this form.
>
> Running "make coccicheck" will find this, but of course you need to have
> coccinelle installed. Note that if it finds anything, "make" won't
> report an error. You have to check for non-empty files in
> contrib/coccinelle/*.patch.

Thank you! I'll give it a try.

-- Sergey Organov