Re: [PATCH 02/16] sha1_file: refactor into `find_pack_object_pos`
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Jun 25, 2013, 13:59 UTC
- Message-ID
- <87fvw5nae9.fsf@linux-k42r.v.cablecom.net>
- In-Reply-To
- <1372116193-32762-3-git-send-email-tanoku@gmail.com>
Vicent Marti <tanoku@gmail.com> writes:
Show 8 quoted lines
> if (use_lookup) {
> - int pos = sha1_entry_pos(index, stride, 0,
> - lo, hi, p->num_objects, sha1);
> - if (pos < 0)
> - return 0;
> - return nth_packed_object_offset(p, pos);
> + return sha1_entry_pos(index, stride, 0, lo, hi, p->num_objects, sha1);
> }Our house style prefers not having the braces in a single-line conditional.
--
Thomas Rast
trast@{inf,student}.ethz.ch