Re: [PATCH v2] cache_tree_find(): remove redundant checks

From: David Kastrup <dak@gnu.org>
Date: Mar 5, 2014, 04:38 UTC
Message-ID: <87eh2hi7jk.fsf@fencepost.gnu.org>
In-Reply-To: <xmqq8uspk72g.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>>  	while (*path) {
>> -		const char *slash;
>>  		struct cache_tree_sub *sub;
>> +		const char *slash = strchr(path, '/');
>>  
>> -		slash = strchr(path, '/');
>>  		if (!slash)
>>  			slash = path + strlen(path);
>
> Isn't the above a strchrnul()?

Yes. I realized that previously, but since it's a GNU extension rather than part of the C standards, I discarded that idea. Calling

    git grep strchrnul

shows, however, that it _is_ used plentifully already.

That would, indeed, favor the current proposal but with strchnul.

Still worth thinking about whether there is no better name than slash for something that indicated the end of the current path name segment.

-- 
David Kastrup