Re: [PATCH v2] cache_tree_find(): remove redundant checks
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Mar 4, 2014, 22:24 UTC
- Message-ID
- <531652B9.4000001@alum.mit.edu>
- In-Reply-To
- <xmqq8uspk72g.fsf@gitster.dls.corp.google.com>
On 03/04/2014 10:05 PM, Junio C Hamano wrote:
Show 12 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> while (*path) {
>> - const char *slash;
>> struct cache_tree_sub *sub;
>> + const char *slash = strchr(path, '/');
>>
>> - slash = strchr(path, '/');
>> if (!slash)
>> slash = path + strlen(path);
>
> Isn't the above a strchrnul()?Oh, cool, I never realized that this GNU extension was blessed for use in Git. Will change.
> Combining a freestanding decl with intializer assignment to lose one > line is sort of cheating on the line count, but replacing the three > lines with a single strchrnul() would be a real code reduction ;-)
I suppose you are just teasing me, but for the record I consider line count only a secondary metric. The reason for combining initialization with declaration is to reduce by one the number of times that the reader has to think about that variable when analyzing the code.
And as I am writing this I realize that after converting to the use of strchrnul(), sub can also be initialized at its declaration.
I really wish we could mix declarations with statements because I think it is a big help to readability.
Michael
-- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/