git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-files: Don't require exclude files to end with a newline.

From
AJAlexandre Julliard <julliard@winehq.org>
Date
Mar 20, 2006, 09:14 UTC
Message-ID
<87d5ghbhra.fsf@wine.dyndns.org>
In-Reply-To
<20060319212911.GD18185@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 15 quoted lines
> Dear diary, on Sat, Mar 18, 2006 at 11:27:45AM CET, I got a letter
> where Alexandre Julliard <julliard@winehq.org> said that...
>> Without this patch, the last line of an exclude file is silently
>> ignored if it doesn't end with a newline.
>> 
>> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
>
> $ echo -en "a\nb" | wc -l
> 1
>
> In UNIX, a line is a string terminated by a newline, therefore the blob
> past the last newline character is not really a line at all. ;-)
>
> Perhaps a warning might be in order. Why don't you just add the trailing
> newline to the file?

Of course I can do that, but I think that if a user entered something on the last line it's a safe bet they didn't mean for it to be ignored; and since it's trivial to DTRT here, I don't see why we shouldn't.

-- 
Alexandre Julliard
julliard@winehq.org
Previous: Petr Baudis
Message 3 of 3 in “ls-files: Don't require exclude files to end with a newline.”
  1. ls-files: Don't require exclude files to end with a newline.Alexandre Julliard, Mar 18, 2006
  2. Petr BaudisMar 19, 2006
  3. Alexandre JulliardMar 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.