git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] ls-files: Don't require exclude files to end with a newline.

From
AJAlexandre Julliard <julliard@winehq.org>
Date
Mar 18, 2006, 10:27 UTC
Message-ID
<8764mccaji.fsf@wine.dyndns.org>

Without this patch, the last line of an exclude file is silently ignored if it doesn't end with a newline.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 ls-files.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
9c5a78851bcf3b541364f818f6b397c29a8f4592
diff --git a/ls-files.c b/ls-files.c
index df25c8c..e42119c 100644
--- a/ls-files.c
+++ b/ls-files.c
@@ -92,11 +92,12 @@ static int add_excludes_from_file_1(cons
 		close(fd);
 		return 0;
 	}
-	buf = xmalloc(size);
+	buf = xmalloc(size+1);
 	if (read(fd, buf, size) != size)
 		goto err;
 	close(fd);
 
+	buf[size++] = '\n';
 	entry = buf;
 	for (i = 0; i < size; i++) {
 		if (buf[i] == '\n') {
-- 
1.2.4.g5a1f-dirty

-- 
Alexandre Julliard
julliard@winehq.org
Next: Petr Baudis
Message 1 of 3 in “ls-files: Don't require exclude files to end with a newline.”
  1. ls-files: Don't require exclude files to end with a newline.Alexandre Julliard, Mar 18, 2006
  2. Petr BaudisMar 19, 2006
  3. Alexandre JulliardMar 20, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.