From: Alexandre Julliard Date: Mon, 20 Mar 2006 09:14:01 GMT Subject: Re: [PATCH] ls-files: Don't require exclude files to end with a newline. Message-ID: <87d5ghbhra.fsf@wine.dyndns.org> In-Reply-To: <20060319212911.GD18185@pasky.or.cz> Petr Baudis writes: > Dear diary, on Sat, Mar 18, 2006 at 11:27:45AM CET, I got a letter > where Alexandre Julliard said that... >> Without this patch, the last line of an exclude file is silently >> ignored if it doesn't end with a newline. >> >> Signed-off-by: Alexandre Julliard > > $ echo -en "a\nb" | wc -l > 1 > > In UNIX, a line is a string terminated by a newline, therefore the blob > past the last newline character is not really a line at all. ;-) > > Perhaps a warning might be in order. Why don't you just add the trailing > newline to the file? Of course I can do that, but I think that if a user entered something on the last line it's a safe bet they didn't mean for it to be ignored; and since it's trivial to DTRT here, I don't see why we shouldn't. -- Alexandre Julliard julliard@winehq.org