Re: [PATCH 1/2] perf: compare diff algorithms

From: Thomas Rast <trast@inf.ethz.ch>
Date: Mar 7, 2012, 12:44 UTC
Message-ID: <877gywy40l.fsf@thomas.inf.ethz.ch>
In-Reply-To: <m31up5tnjw.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 17 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> But of course, this from a command line would not work:
>> 
>> 	$ perl -MGit
>> 
>> I do not expect it to, and for the ease of testing new versions, I
>> prefer it not to work.
>> 
>> In any case, you should be able to do anything under t/ _before_
>> installing, so relying on having Git.pm in normal @INC is a double
>> no-no.
>
> Thomas, take a look at how it is solved in 't/t9700/test.pl', used by
> 't/t9700-perl-git.sh':
>
>   use lib (split(/:/, $ENV{GITPERLLIB}));

Hum. The problem is that the user may invoke aggregate.perl manually, and GITPERLLIB won't be set in that case.

Is there a better solution than duplicating the logic that sets GITPERLLIB in test-lib.sh within aggregate.perl?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch