git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config: Introduce --patience config variable

From
Jeff King <peff@peff.net>
Date
Mar 6, 2012, 14:09 UTC
Message-ID
<20120306140911.GA22329@sigill.intra.peff.net>
In-Reply-To
<vpqr4x5hmt3.fsf@bauges.imag.fr>
On Tue, Mar 06, 2012 at 02:38:16PM +0100, Matthieu Moy wrote:
Show 12 quoted lines
> Michal Privoznik <mprivozn@redhat.com> writes:
> 
> > Okay guys. I'll got with diff.algorithm = [patience | minimal |
> > histogram | myers] then. What I am not sure about is how to threat case
> > when user have say algorithm = patience set in config but want to use
> > myers. I guess we need --myers option then, don't we?
> 
> At this point, maybe it's time to have
> --diff-algorithm=[patience|minimal|histogram|myers], and keep
> --patience, --minimal and --histogram just as compatibility aliases.
> 
> Having one option per algorithm feels wrong ...

Yeah, that was going to be my suggestion, too. And explaining it that way in the docs will make it clear that "--histogram" overrides "--patience" and so forth.

-Peff
Previous: Matthieu MoyNext: Junio C Hamano
Message 20 of 23 in “config: Introduce --patience config variable”
  1. config: Introduce --patience config variableMichal Privoznik, Mar 6, 2012
  2. Jeff KingMar 6, 2012
  3. Thomas RastMar 6, 2012
  4. 1/2 perf: compare diff algorithmsThomas Rast, Mar 6, 2012
  5. 2/2 Document the --histogram diff optionThomas Rast, Mar 6, 2012
  6. Junio C HamanoMar 6, 2012
  7. Thomas RastMar 6, 2012
  8. Junio C HamanoMar 6, 2012
  9. Thomas RastMar 6, 2012
  10. Junio C HamanoMar 6, 2012
  11. Jakub NarebskiMar 6, 2012
  12. Thomas RastMar 7, 2012
  13. Junio C HamanoMar 7, 2012
  14. Jakub NarebskiMar 7, 2012
  15. Junio C HamanoMar 7, 2012
  16. René ScharfeMar 10, 2012
  17. Jeff KingMar 6, 2012
  18. Michal PrivoznikMar 6, 2012
  19. Matthieu MoyMar 6, 2012
  20. Jeff KingMar 6, 2012
  21. Junio C HamanoMar 7, 2012
  22. Jeff KingMar 7, 2012
  23. Junio C HamanoMar 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.