Re: [PATCH 1/2] perf: compare diff algorithms

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2012, 18:19 UTC
Message-ID: <7vzkbsmfyk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201203071903.02373.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Beside extracting logic that sets GITPERLLIB into separate file like
> in Junio proposal?

That was not even a proposal. The part that deals with valgrind is blatantly wrong (it shouldn't create symlinks in that code, it only should figure out where things should be).

Show 5 quoted lines

> You can always assume that it is fixed relative
> to perl/Git.pm, and use __DIR__ or $FindBin to make "use lib", e.g.
>
>   use FindBin;
>   use lib "$FindBin::Bin/../../perl";

Use of FindBin to find the location of the script is OK, but does using "../../perl" really work?

We have this

  GITPERLLIB="$GIT_BUILD_DIR"/perl/blib/lib:"$GIT_BUILD_DIR"/perl/blib/arch/auto/Git

to look for two places in test-lib.sh