git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

From
Thomas Rast <tr@thomasrast.ch>
Date
Oct 26, 2013, 08:35 UTC
Message-ID
<877gd0pgze.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<20131024084638.GA761@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
> index 752f5cb..2b4b9a9 100755
[...]
> +test_atom head *objectname ''
> +test_atom head *objecttype ''
[...]
> +test_atom tag *objectname '67a36f10722846e891fbada1ba48ed035de75581'
> +test_atom tag *objecttype 'commit'

Can you quote the *? I may have become somewhat paranoid, but still. This is the first use of the *<field> syntax, and test_atom seems written to correctly quote its arguments, so why risk it? :-)

-- 
Thomas Rast
tr@thomasrast.ch
Previous: Jeff KingNext: Jeff King
Message 2 of 4 in “for-each-ref: avoid loading objects to print %(objectname)”
  1. for-each-ref: avoid loading objects to print %(objectname)Jeff King, Oct 24, 2013
  2. Thomas RastOct 26, 2013
  3. Jeff KingOct 30, 2013
  4. Junio C HamanoOct 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.