From: Thomas Rast <tr@thomasrast.ch>
Date: Sat, 26 Oct 2013 08:35:17 GMT
Subject: Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)
Message-ID: <877gd0pgze.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <20131024084638.GA761@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
> index 752f5cb..2b4b9a9 100755
[...]
> +test_atom head *objectname ''
> +test_atom head *objecttype ''
[...]
> +test_atom tag *objectname '67a36f10722846e891fbada1ba48ed035de75581'
> +test_atom tag *objecttype 'commit'

Can you quote the *?  I may have become somewhat paranoid, but still.
This is the first use of the *<field> syntax, and test_atom seems
written to correctly quote its arguments, so why risk it? :-)

-- 
Thomas Rast
tr@thomasrast.ch