Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 30, 2013, 17:34 UTC
Message-ID: <xmqqa9hqd5n3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131030065016.GB11317@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Sat, Oct 26, 2013 at 10:35:17AM +0200, Thomas Rast wrote:
> ...
>> Can you quote the *?  I may have become somewhat paranoid, but still.
>> This is the first use of the *<field> syntax, and test_atom seems
>> written to correctly quote its arguments, so why risk it? :-)
>
> Yeah, that is a very reasonable suggestion. And the patch is still in
> pu, so it's not too late to squash.
>
> Junio, here is a resend with the asterisks quoted, to replace what's in
> jk/for-each-ref-skip-parsing.  I also double-checked that test_atom
> keeps them properly quoted (it does).

Thanks, both, for being careful.