Re: [PATCH] general style: replaces memcmp() with proper starts_with()

From: David Kastrup <dak@gnu.org>
Date: Mar 13, 2014, 06:27 UTC
Message-ID: <877g7yipf9.fsf@fencepost.gnu.org>
In-Reply-To: <xmqqha73jb6q.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Taking two random examples from an early and a late parts of the
> patch:
>
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -82,7 +82,7 @@ static int cat_one_file(int opt, const char *exp_type, const char *obj_name)
>  				enum object_type type;
>  				unsigned long size;
>  				char *buffer = read_sha1_file(sha1, &type, &size);
> -				if (memcmp(buffer, "object ", 7) ||
> +				if (!starts_with(buffer, "object ") ||

[...]

> The original hunks show that the code knows and relies on magic
> numbers 7 and 8 very clearly and there are rooms for improvement.

Like: what if the file is empty?

-- 
David Kastrup