Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

From: David Kastrup <dak@gnu.org>
Date: Mar 25, 2014, 20:32 UTC
Message-ID: <8738i6uihf.fsf@fencepost.gnu.org>
In-Reply-To: <xmqqtxamkq4b.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 20 quoted lines

> Elia Pinto <gitter.spiros@gmail.com> writes:
>
>> The Git CodingGuidelines prefer the $( ... ) construct for command
>> substitution instead of using the back-quotes, or grave accents (`..`).
>>
>> The backquoted form is the historical method for command substitution,
>> and is supported by POSIX. However, all but the simplest uses become
>> complicated quickly. In particular, embedded command substitutions
>> and/or the use of double quotes require careful escaping with the backslash
>> character. Because of this the POSIX shell adopted the $(…) feature from
>> the Korn shell.
>>
>> The patch was generated by the simple script
>>
>> for _f in $(find . -name "*.sh")
>> do
>>   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
>> done
>
> "and then carefully proofread" is sorely needed here.

It would already help to skip comment lines.

-- 
David Kastrup