[PATCH v2 087/142] t7006-pager.sh: use the $( ... ) construct for command substitution
- From
Elia Pinto <gitter.spiros@gmail.com>
- Date
- Mar 25, 2014, 17:23 UTC
- Message-ID
- <1395768283-31135-88-git-send-email-gitter.spiros@gmail.com>
- In-Reply-To
- <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`).
The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell.
The patch was generated by the simple script
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
doneSigned-off-by: Elia Pinto <gitter.spiros@gmail.com> --- t/t7006-pager.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh index b9365b4..7576fa9 100755 --- a/t/t7006-pager.sh +++ b/t/t7006-pager.sh @@ -436,7 +436,7 @@ test_expect_success TTY 'command-specific pager works for external commands' ' echo "foo:initial" >expect && >actual && test_config pager.external "sed s/^/foo:/ >actual" && - test_terminal git --exec-path="`pwd`" external log --format=%s -1 && + test_terminal git --exec-path="$(pwd)" external log --format=%s -1 && test_cmp expect actual '
-- 1.7.10.4