[PATCH v2 077/142] t5900-repo-selection.sh: use the $( ... ) construct for command substitution
- From
Elia Pinto <gitter.spiros@gmail.com>
- Date
- Mar 25, 2014, 17:23 UTC
- Message-ID
- <1395768283-31135-78-git-send-email-gitter.spiros@gmail.com>
- In-Reply-To
- <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com>
The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`).
The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell.
The patch was generated by the simple script
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
doneSigned-off-by: Elia Pinto <gitter.spiros@gmail.com> --- t/t5900-repo-selection.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5900-repo-selection.sh b/t/t5900-repo-selection.sh index 3d5b418..14e59c5 100755 --- a/t/t5900-repo-selection.sh +++ b/t/t5900-repo-selection.sh @@ -15,7 +15,7 @@ make_tree() { make_bare() { git init --bare "$1" && (cd "$1" && - tree=`git hash-object -w -t tree /dev/null` && + tree=$(git hash-object -w -t tree /dev/null) && commit=$(echo "$1" | git commit-tree $tree) && git update-ref HEAD $commit )
-- 1.7.10.4