git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 06/12] builtin/update_ref: convert to struct object_id

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 3, 2017, 20:49 UTC
Message-ID
<8737adckkc.fsf@gmail.com>
In-Reply-To
<20170703185533.51530-7-sandals@crustytoothpaste.net>
On Mon, Jul 03 2017, brian m. carlson jotted:
> Convert the uses of unsigned char * to struct object_id.

I read all of this over (but didn't apply/test it) and it looks good to me, Just a small nit:

Show 9 quoted lines
> [...]
>  1 file changed, 34 insertions(+), 35 deletions(-)
> [...]
>  	struct strbuf err = STRBUF_INIT;
>  	char *refname;
> -	unsigned char new_sha1[20];
> -	unsigned char old_sha1[20];
> +	struct object_id new_oid, old_oid;
> [...]

It's easier to skim these when you leave changes in the number of lines to separate commits which do more than just rename boilerplate code, e.g. as in 05/12 where `const char *p` is introduced.

Thanks for working on this.
Previous: brian m. carlsonNext: brian m. carlson
Message 10 of 20 in “object_id part 9”
  1. 00/12 object_id part 9brian m. carlson, Jul 3, 2017
  2. 01/12 builtin/fsck: convert remaining caller of get_sha1 to object_idbrian m. carlson, Jul 3, 2017
  3. 07/12 bisect: convert bisect_checkout to struct object_idbrian m. carlson, Jul 3, 2017
  4. 05/12 sequencer: convert to struct object_idbrian m. carlson, Jul 3, 2017
  5. 04/12 remote: convert struct push_cas to struct object_idbrian m. carlson, Jul 3, 2017
  6. 02/12 builtin/merge-tree: convert remaining caller of get_sha1 to object_idbrian m. carlson, Jul 3, 2017
  7. 08/12 builtin/unpack-file: convert to struct object_idbrian m. carlson, Jul 3, 2017
  8. 10/12 Convert remaining callers of get_sha1 to get_oid.brian m. carlson, Jul 3, 2017
  9. 06/12 builtin/update_ref: convert to struct object_idbrian m. carlson, Jul 3, 2017
  10. Ævar Arnfjörð BjarmasonJul 3, 2017
  11. brian m. carlsonJul 4, 2017
  12. 03/12 submodule: convert submodule config lookup to use object_idbrian m. carlson, Jul 3, 2017
  13. 09/12 builtin/verify-tag: convert to struct object_idbrian m. carlson, Jul 3, 2017
  14. 12/12 sha1_name: convert GET_SHA1* flags to GET_OID*brian m. carlson, Jul 3, 2017
  15. 11/12 sha1_name: convert get_sha1* to get_oid*brian m. carlson, Jul 3, 2017
  16. Stefan BellerJul 5, 2017
  17. Junio C HamanoJul 5, 2017
  18. brian m. carlsonJul 7, 2017
  19. Junio C HamanoJul 5, 2017
  20. Stefan BellerJul 5, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.