From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 03 Jul 2017 20:49:39 GMT
Subject: Re: [PATCH 06/12] builtin/update_ref: convert to struct object_id
Message-ID: <8737adckkc.fsf@gmail.com>
In-Reply-To: <20170703185533.51530-7-sandals@crustytoothpaste.net>


On Mon, Jul 03 2017, brian m. carlson jotted:

> Convert the uses of unsigned char * to struct object_id.

I read all of this over (but didn't apply/test it) and it looks good to
me, Just a small nit:

> [...]
>  1 file changed, 34 insertions(+), 35 deletions(-)
> [...]
>  	struct strbuf err = STRBUF_INIT;
>  	char *refname;
> -	unsigned char new_sha1[20];
> -	unsigned char old_sha1[20];
> +	struct object_id new_oid, old_oid;
> [...]

It's easier to skim these when you leave changes in the number of lines
to separate commits which do more than just rename boilerplate code,
e.g. as in 05/12 where `const char *p` is introduced.

Thanks for working on this.